Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration for ecosystem members #8

Merged
merged 13 commits into from
Sep 20, 2021

Conversation

IceKhan13
Copy link
Member

@IceKhan13 IceKhan13 commented Aug 25, 2021

Summary

Adds configuration specification and parser for running tests.

TODOS:

  • configuration for repositories
  • add version of qiskit to tests
  • resolve repositories without setup.py

Closes #7

@IceKhan13 IceKhan13 added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 25, 2021
@IceKhan13 IceKhan13 self-assigned this Aug 25, 2021
@IceKhan13 IceKhan13 changed the title Configuration: configuration for repository Configuration for ecosystem members Aug 25, 2021
@IceKhan13 IceKhan13 marked this pull request as ready for review August 30, 2021 19:07
@IceKhan13
Copy link
Member Author

IceKhan13 commented Sep 7, 2021

Ecosystem workflows configuration

In order to talk control of execution workflow of tests in ecosystem
repository should have qe_config.json file (we can rename it in future) in a root directory.

Structure of config file:

  • dependencies_files: list[string] - files with package dependencies to install (ex: requirements.txt, packages.json)
  • extra_dependencies: list[string] - names of additional packages to install before tests execution
  • language: string - programming language for tests env. Only supported lang is Python at this moment.
  • tests_command: list[string] - list of commands to execute tests

Example:

{
    "dependencies_files": [
        "requirements.txt",
        "requirements-dev.txt"
    ],
    "extra_dependencies": [
        "pytest"
    ],
    "language": "python",
    "tests_command": [
        "pytest -p no:warnings --pyargs test"
    ]
}

@IceKhan13 IceKhan13 merged commit 4002d1c into Qiskit:main Sep 20, 2021
@IceKhan13 IceKhan13 deleted the issue-7/configuration-for-tests branch September 20, 2021 18:36
@1ucian0
Copy link
Member

1ucian0 commented Sep 24, 2021

Maybe add python version? it could also be in the language section: "language": "python3.8"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurations for running tests for members
2 participants